Exclude namespaces #30
Merged
+75
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Adds support for excluding specific Kubernetes namespaces from deployment-tracker monitoring via a new CLI flag.
Changes:
- Extends CLI with
-exclude-namespacesand prevents using it together with-namespace. - Refactors controller informer setup into
createInformerFactory(...)and adds field-selector-based namespace exclusion. - Documents the new flag and the mutual exclusivity rule in the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/controller/controller.go |
Refactors informer factory creation and adds field-selector logic to exclude namespaces. |
cmd/deployment-tracker/main.go |
Introduces -exclude-namespaces flag, validation, and passes it into the controller. |
README.md |
Documents the new CLI flag and notes that it can’t be combined with -namespace. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
malancas
reviewed
Feb 3, 2026
malancas
left a comment
malancas
left a comment
There was a problem hiding this comment.
The copilot comments make sense to me. Looks good overall
malancas
approved these changes
Feb 3, 2026
ajbeattie
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
-exclude-namespacesflag that accepts a comma separated list of namespaces to exclude from monitoring.I checked to see if the
-namespaceflag could also accept a comma separated list but it seemsFieldSelectorANDs together multiple values and you cannot OR them together.